♻️ Fix `assume` Condition in `testFuzz_ShouldBeAFunctionOfMultipleBlockPropertiesAndTheCaller`

pcaversaccio / createx

Factory smart contract to make easier and safer usage of the `CREATE` and `CREATE2` EVM opcodes as well as of `CREATE3`-based (i.e. without an initcode factor) contract creations.

https://createx.rocks

GNU Affero General Public License v3.0

303 stars 18 forks source link

♻️ Fix `assume` Condition in `testFuzz_ShouldBeAFunctionOfMultipleBlockPropertiesAndTheCaller` #92

Closed pcaversaccio closed 6 months ago

pcaversaccio commented 6 months ago

🕓 Changelog

The fuzzing parameter msgSender in testFuzz_ShouldBeAFunctionOfMultipleBlockPropertiesAndTheCaller must not equal SELF (i.e. address(this), the test contract) for the following negative assertion to always hold:

vm.startPrank(msgSender);
assertNotEq(originalSalt, createXHarness.exposed_generateSalt(), "1100");
vm.stopPrank();

🐶 Cute Animal Picture

github-actions[bot] commented 6 months ago

Coverage after merging fix-generateSalt-test into main will be

100.00%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
src
CreateX.sol	100%	100%	100%	100%

pcaversaccio commented 6 months ago

Merging since I will add DOS deployment today and I want a clean CI :)