Ripper Error if a proxy is defined but no port/user/password is

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Define a http_proxy environment variable
2. but don't include a user name:password.  Eg:
http_proxy=http://localhost:3128 instead of
http_proxy=http://foo:bar@localhost:3128
3. Net:HTTP.new call will fail because of this:
@proxy.port, @proxy.user, CGI.unescape(@proxy.password)

CGI.unescape cannot unescape something that is nil

What is the expected output? What do you see instead?
It should work! ;-)  I'm attaching a patch to fix this issue I created in
an earlier patch! ;-)

1) What version of rubyripper are you using? On what operating system?
0.5.4

2) Are you using the gtk2 or the commandline interface?
cli

3) Is the problem gone with the default settings? If so, please attach your
settings file ($HOME/.rubyripper/settings).
Nope

Original issue reported on code.google.com by mathie...@gmail.com on 13 Jan 2009 at 10:48

Attachments:

• proxy2.patch

[GoogleCodeExporter]

A friend of mine suggested this rubier syntax...  Take your pick...

Original comment by mathie...@gmail.com on 13 Jan 2009 at 10:58

Attachments:

• proxy2.patch

[GoogleCodeExporter]

I liked the 2nd better due to cleaner syntax. It's in latest git:
http://github.com/rubyripperdev/rubyripper/commits/master

Thanks for contributing once again :)

Original comment by rubyripp...@gmail.com on 13 Jan 2009 at 11:24

• Changed state: Fixed