pccasto / rubyripper

Automatically exported from code.google.com/p/rubyripper
0 stars 0 forks source link

program terminates if artist name contains a "/" #272

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Try to rip an CD from e.g. "AC/DC", where a "/" is contained
2. Start grabbing
3.

What is the expected output? What do you see instead?
I would expect rubyripper to start the ripping. Instead the GUI hangs, the
last output is "STATUS". This is the error from the shell:

/usr/local/rubyripper/local/lib/site_ruby/1.8/rr_lib.rb:370:in
`initialize': No such file or directory - /home/chriss/mp3_ripping/mp3/AC
DC - (0) - Black Ice/AC/DC - Black Ice (mp3).cue (Errno::ENOENT)
    from /usr/local/rubyripper/local/lib/site_ruby/1.8/rr_lib.rb:370:in `new'
    from /usr/local/rubyripper/local/lib/site_ruby/1.8/rr_lib.rb:370:in
`saveCuesheet'
    from /usr/local/rubyripper/local/lib/site_ruby/1.8/rr_lib.rb:307:in
`initialize'
    from /usr/local/rubyripper/local/lib/site_ruby/1.8/rr_lib.rb:1080:in `new'
    from /usr/local/rubyripper/local/lib/site_ruby/1.8/rr_lib.rb:1080:in
`initialize'
    from /usr/local/rubyripper/local/lib/site_ruby/1.8/rr_lib.rb:1077:in `each'
    from /usr/local/rubyripper/local/lib/site_ruby/1.8/rr_lib.rb:1077:in
`initialize'
    from /usr/local/rubyripper/local/lib/site_ruby/1.8/rr_lib.rb:1360:in `new'
    from /usr/local/rubyripper/local/lib/site_ruby/1.8/rr_lib.rb:1360:in
`start_rip'
    from ./rrip_gui:233:in `do_rip'
    from ./rrip_gui:229:in `initialize'
    from ./rrip_gui:229:in `new'
    from ./rrip_gui:229:in `do_rip'
    from ./rrip_gui:1009:in `initialize'
    from ./rrip_gui:1118:in `call'
    from ./rrip_gui:1118:in `main'
    from ./rrip_gui:1118

When removing the "/" from the Artist-Name, everything is working fine.
I guess, the "/" is not escaped, and so the program crashes...

1) What version of rubyripper are you using? On what operating system?
Latest version from git
2) Are you using the gtk2 or the commandline interface?
gtk2 started from commandline
3) Is the problem gone with the default settings? If so, please attach your
settings file ($HOME/.rubyripper/settings).

Please provide any additional information below.

Original issue reported on code.google.com by chriss...@gmail.com on 28 Jan 2009 at 9:31

Attachments:

GoogleCodeExporter commented 8 years ago
Can you confirm it works fine when the cuesheet is disabled?

Original comment by rubyripp...@gmail.com on 28 Jan 2009 at 9:49

GoogleCodeExporter commented 8 years ago
Yes. When disabling the cuesheet, it works.

Original comment by chriss...@gmail.com on 29 Jan 2009 at 6:44

GoogleCodeExporter commented 8 years ago
Thanks, then we narrowed it down quite nicely. 

Note to myself. To solve this I see two options:
* Pass the output dirname to the Cuesheet class instead of attemtping to 
recreate it.
* Take a better attempt to recreate the dirname.

Original comment by rubyripp...@gmail.com on 29 Jan 2009 at 7:07

GoogleCodeExporter commented 8 years ago
I've implemented option 2 in the same way as the Encode class does it. I expect 
to
have this solved. I've tested this for artist AC/DC.

Original comment by rubyripp...@gmail.com on 29 Jan 2009 at 10:43