pccasto / rubyripper

Automatically exported from code.google.com/p/rubyripper
0 stars 0 forks source link

Enhancement - Volume normalize - could replaygain add tags for values of both track and album gains? #276

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Hi developers,

I would like to suggest an enhancement. Usually after I rip my CDs into
FLAC, I like to calculate and apply replaygain tags for values of both
track (radio mode) and album gains. It makes sense to me because I would
use track mode when listening through my mp3 player (when supported in
future mp3 players) so that I don't blast my ears due to varying volumes
and album gain when listening more attentively through my hi-fi setup at
home. Currently, Rubbyripper only permits adding either track or album
gains, but not both together. Would it be possible to implement calculating
and tagging gains for both values after a CD rip? Ordinarily, I would use
the command of the flac tools ... ~$ metaflac --add-replaygain *.flac ...
to get the job done. But if you're able to automate this task, I think it
would be another ruby in the crown of this great ripper.

Original issue reported on code.google.com by martin.c...@gmail.com on 5 Feb 2009 at 12:22

GoogleCodeExporter commented 8 years ago
It already does this if you choose album gain I think.

#current code is as follows:
command = "metaflac --add-replay-gain \"#{if @settings['gain'] =="track" : 
filename
else File.dirname(filename) + "\"/*.flac" end}"

It starts with "metaflac --add-replay-gain ". Then follows some logic. This 
means
that if replaygain is not like track (think album), the argument "dir/*.flac" 
is passed.

So the question is: do you think it does not work or did you actually verify 
this?

Original comment by rubyripp...@gmail.com on 5 Feb 2009 at 10:39

GoogleCodeExporter commented 8 years ago
I beg your pardon. I did not do my homework. Rubyripper does tag replaygain 
values
for both track and album gains. This used to be a problem when I used other 
rippers
such as GRIP. Good work chaps! Issue only existed in my imagination. Case 
closed.

Original comment by martin.c...@gmail.com on 6 Feb 2009 at 9:47

GoogleCodeExporter commented 8 years ago
Thanks for your reply :)

Original comment by rubyripp...@gmail.com on 6 Feb 2009 at 4:13