search

pcdshub / engineering_tools

A repository of scripts, configuration useful for the PCDS team
Other
4 stars 27 forks source link

MNT: Cleanup of a few files #104

Closed ZryletTC closed 2 years ago

ZryletTC commented 2 years ago

Description and Context

A little bit a cleanup of epicsArchChecker following #103. There is one big commit that is just capitalization changes that unfortunately makes this file a bit harder to review, sorry.

One line removed from ami_offline_psana from my comment in #100.

I also could have sworn we decided to use latest-released as opposed to latest for engineering_tools. Did we change our minds at some point? This PR changes it but we can take that out if there was some reason.

Lastly, this fixes the -m option for restartdaq, which allows you to specify a different machine to run the daq on. This option has been around forever but I'm not sure that it ever worked. This fix makes it work but if it's not desired, we should just remove the option entirely.

How Has This Been Tested?

Interactively in CXI

Where Has This Been Documented?

These are all fixes/cleanup commits. No features/API changed. (except maybe the bashrc, but I don't really thinks that needs to be documented)

ZryletTC commented 2 years ago

If the restartdaq part is accepted, restartdaq (and stopdaq) should eventually handle remote sessions a bit more elegantly. It works fine but restartdaq currently runs in a foreground ssh session that you have to Ctrl-C from to exit and stopdaq has no remote handling at the moment.

silkenelson commented 2 years ago

I've merged this as I'd like to make a tag/release so that I can move TMO to have a working epicsArchChecker.