search

pcdshub / lcls-plc-sample-delivery-system

https://pcdshub.github.io/lcls-plc-sample-delivery-system/
Other
2 stars 7 forks source link

Revamp io #7

Closed slacAWallace closed 4 years ago

slacAWallace commented 4 years ago

I decided to overhaul the IO in this project so future modifications can proceed more smoothly.

I am in the process of revamping this project to have more modular code as well. Nothing was a function block and that's silly. Will also include pytmc in the near near future.

rajanplumley commented 4 years ago

@slacAWallace What is your thinking behind changing the PV names?

slacAWallace commented 4 years ago

@slacAWallace What is your thinking behind changing the PV names?

Not sure which you're referring to, but I think maybe I was trying to refactor some of the naming decisions I had made a long time ago. Someone told me the names were not conducive for ophyd.

rajanplumley commented 4 years ago

@slacAWallace What is your thinking behind changing the PV names?

Not sure which you're referring to, but I think maybe I was trying to refactor some of the naming decisions I had made a long time ago. Someone told me the names were not conducive for ophyd.

Okay, that makes sense. I just wanted to understand why some of the PV names were changing.

rajanplumley commented 4 years ago

if nobody objects I'm going to make all the stBaseIO have the same name in the DUT and give them the same pytmc suffix ("IO").

ZryletTC commented 4 years ago

Anything left to do on this PR?

ZryletTC commented 4 years ago

Well I guess Raj is gone, so I'm deciding it is done.