search

pcdshub / pcdswidgets

LCLS PyDM Widget Library
https://pcdshub.github.io/pcdswidgets
Other
0 stars 10 forks source link

Allow for custom ui file to be open when widget icon is pressed. #77

Closed jozamudi closed 1 year ago

jozamudi commented 1 year ago

Description

When device widget icon is pressed a predefined screen will appear as a tab in the typhos screen. If no screen is defined typhos works as usual.

Motivation and Context

Allows for more information to be displayed about a device, such as interlock information. https://jira.slac.stanford.edu/browse/LCLSECSD-1735

How Has This Been Tested?

Made a test screen that contains a pcds widget and checked the behavior when the icon is pressed. Tested variation of inputs in designer properties.

Where Has This Been Documented?

ZLLentz commented 1 year ago

Hold up- actually, I'm not clicking merge because the automated test failed. Let's take a look.

ZLLentz commented 1 year ago

It failed on basic internet connectivity breaking during the test runner- I'll re-run the failing test elements.

ZLLentz commented 1 year ago

Something is wrong with our cloud CI tests- I ran the equivalent test locally and it passed, so I'll merge this despite the apparent cloud failure.