search

pcuzner / ansible-runner-service

Python project that wraps the ansible_runner 'engine' inside a RESTful API
Other
17 stars 9 forks source link

Restructured test code to use flask test client #69

Closed pcuzner closed 6 years ago

codecov-io commented 6 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@5463103). Click here to learn what that means. The diff coverage is 97.12%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #69   +/-   ##
=========================================
  Coverage          ?   87.04%           
=========================================
  Files             ?       30           
  Lines             ?     1598           
  Branches          ?        0           
=========================================
  Hits              ?     1391           
  Misses            ?      207           
  Partials          ?        0
Impacted Files Coverage Δ
runner_service/services/playbook.py 81.48% <ø> (ø)
tests/test_api_events.py 97.61% <100%> (ø)
tests/test_api_playbooks.py 98.61% <100%> (ø)
tests/test_api_generic.py 96.42% <100%> (ø)
runner_service/controllers/playbooks.py 83.52% <100%> (ø)
tests/test_api_login.py 97.14% <100%> (ø)
ansible_runner_service.py 62.22% <83.33%> (ø)
tests/common.py 90.9% <86.95%> (ø)
tests/test_api_inventory.py 96.66% <98.57%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5463103...7c099f6. Read the comment docs.

jmolmo commented 6 years ago

What about to avoid to copy the tests to a tmp folder?

Apart of that, it is now more clean !! LGTM. Ship it!