pdiezvig / dasmoto

Dasmoto project
0 stars 0 forks source link

SUMMARY #5

Open sangjunp4rk opened 7 years ago

sangjunp4rk commented 7 years ago

Summary Grade: Exceeds Expectations

Good job with your code! I really like the use of whitespace! Makes your code very easy to read! Also, good decisions on the classes and ids name. It makes it very clear what its purpose is and makes grouping your sections very effective. These organizational skills come in handy as you expand your code. Finally, good decision to save images locally! Saving images adds to the stability of your website because your website is not reliant on the link to be valid all the time. Great start to the Ready program!

I included a few notes in both the html file for you to think more critically about. First, make sure to add comments to you code. It's important as your code gets increasingly complex and having comments makes it easier to navigate and fix. Finally, you title font seems a bit too large. Try using a smaller font since it takes up so much of the top of the website and screen.

pdiezvig commented 6 years ago

Thanks, @sangjunp4rk. Your comments motivates me! 👍 😄

I'm agree with you about the size of the header font, but I don't understand what's happened. My css says font-size: 100px, but the computed css set 200px. Why this happened.? I send you an screenshot with the Chrome inspector. captura de pantalla 2017-10-03 17 12 18