search

peacechen / react-native-modal-selector

A cross-platform (iOS / Android), selector/picker component for React Native that is highly customizable and supports sections.
MIT License
369 stars 129 forks source link

Add unique option testID for test automation #148

Closed Merlier closed 4 years ago

Merlier commented 4 years ago

Add unique option testID and testIDPrefix prop to support testID automation on options

Reference to issue #77

Signed-off-by: Merlier merlier771@gmail.com

peacechen commented 4 years ago

Thanks @Merlier for contributing to this project. I edited the Readme to clarify the testID behavior which could be a bit confusing. I renamed testIDPrefix to optionsTestIDPrefix in order to clarify what it applies to. There are other components that may have testID's, and I wanted to make sure users know that this prop only affects the selectable options' test ID's.

Merlier commented 4 years ago

Good job 👍 and quickly merged! Thanks @peacechen