search

peacechen / react-native-modal-selector

A cross-platform (iOS / Android), selector/picker component for React Native that is highly customizable and supports sections.
MIT License
369 stars 129 forks source link

Expo update and type fixes #161

Closed mehimanshupatil closed 3 years ago

mehimanshupatil commented 3 years ago

@peacechen 1) updated expo version of sample app to 40.0.0 2) added typescript to sample app 3) converted sample app.tsx from class component to functional 4) fixed types issue occurred in #157 PR @kg-currenxie can you check type error

@peacechen also the type of changedItem state in package is key of selected item or the selected item itself. because in onchange method the selected item is set while initializing state only key is set

mikaello commented 3 years ago

This is great, thanks!

Waiting for https://github.com/peacechen/react-native-modal-selector/issues/168 to be confirmed resolved before merging this (in case of needing to revert the recent changes in main branch).

mikaello commented 3 years ago

Thanks for your contribution, this is available in v2.0.9