Fix: Current release breaks web view in react native (#158) - Githubissues

peacechen / react-native-modal-selector

A cross-platform (iOS / Android), selector/picker component for React Native that is highly customizable and supports sections.

MIT License

369 stars 129 forks source link

Fix: Current release breaks web view in react native (#158) #162

Closed ruru-ink closed 3 years ago

ruru-ink commented 3 years ago

Issue:

Current release breaks web view in react native #158
React Native Web: Breaking Change - Remove prop types exports from package. These are deprecated in React Native and introduce significant DEV time performance cost. Flow types are now preferred (1ad1693)

Done:

Removed references to ViewPropTypes.style & Text.propTypes.style and replaced with standard PropTypes validators. This correcting errors thrown when using the modal selector component in a react-native-web (v0.16) project in Expo (v41)

ruru-ink commented 3 years ago

I added number as an option to the PropTypes based on this answer on StackOverflow

peacechen commented 3 years ago

Thanks @ruru-ink