peachpiecompiler / peachpie

PeachPie - the PHP compiler and runtime for .NET and .NET Core
https://www.peachpie.io
Apache License 2.0
2.33k stars 202 forks source link

warning PHP5014: session_regenerate_id() expects 0 parameter(s), 1 given #1071

Open matbech opened 1 year ago

matbech commented 1 year ago

Incorrect warning issued for session_regenerate_id: warning PHP5014: session_regenerate_id() expects 0 parameter(s), 1 given

 public function regenerateId($deleteOldSession = true)
    {
        if ($this->sessionExists()) {
            session_regenerate_id((bool) $deleteOldSession);
        }

        return $this;
    }

Reference to php manual: https://www.php.net/manual/en/function.session-regenerate-id.php

jakubmisek commented 1 year ago

thank you;

although session_regenerate_id() is not supported by PeachPie (on ASP.NET Core)