search

pediapress / mwlib

mediawiki parser library
103 stars 35 forks source link

Fixes so it works with a more recent gevent package. #62

Closed lwandrebeck closed 6 years ago

lwandrebeck commented 7 years ago

python-gevent 1.1 does not provide anymore coros, replaced by lock method.

lwandrebeck commented 7 years ago

Sorry, looks like there are a couple lines changes between pip install (on armv7l, running ubuntu 16.04.2) and git HEAD. just ignore msg variable changes. Thanks.

v0lk3r commented 6 years ago

I don't really understand the pull request. Do you want to make mwlib compatible with pre 1.1 versions of gevent? The current code works just fine with gevent 1.1+

lwandrebeck commented 6 years ago

Well, 1.1.0 failed on ubuntu 16.04 LTS on armv7l and x86_64 without the lock patch (which is apparently available on 1.1+, coros being not provided anymore). The point was to make it work with 1.1+ and previous versions. Maybe 1.1.0 ubuntu package is buggy, My memory is not that clear about it, it’s been a while :) I’m running with the patch for a while successfully at home. Anyway, thanks for the head’s up !

v0lk3r commented 6 years ago

I just committed https://github.com/pediapress/mwlib/commit/723f992fe283b5789fcd3137edbfc0006773dbdf that should make mwlib compatible to old gevent versions