Closed pedrocol closed 2 years ago
@StephenGriffies I just checked the code and the way Tfreezing is calculated assumes the temperature variable to be potential temperature (see below). This function was imported from NEMO, at that time I didn't find a function to calculate Tfreezing(i,j,k) as a function of pressure and salinity. .
The ACCESS model uses Conservative Temp as its prognostics temp field. Conservative Temp and potential temp differ especially in regions of relatively fresh water. See Figure 7 in McDougall (2003)
https://journals.ametsoc.org/view/journals/phoc/33/5/1520-0485_2003_033_0945_peacov_2.0.co_2.xml
Although I am doubtful this detail matters much, I suggest we do the right thing.
So if Tfreeze is in coded for potential temp, then we simply need to have an option in MOM5 to convert from pot temp to Conservative Temp. That conversion is available in MOM5 in the routine "contemp_from_pottemp", which is inside ocean_tempsalt.F90.
I have included the correction mentioned by Steve
I'm closing the issue, we can re-open it if there is any extra comment
Check if the Tbasal is correct in the sense of being an insitu temperature or a potential temperature