search

pedrovgs / Lynx

Lynx is an Android library created to show a custom view with all the information Android logcat is printing, different traces of different levels will be rendererd to show from log messages to your application exceptions. You can filter this traces, share your logcat to other apps, configure the max number of traces to show or the sampling rate used by the library.
Apache License 2.0
780 stars 94 forks source link

Synchronize all methods that use or modify tracesToNotify #30

Closed stkent closed 7 years ago

stkent commented 7 years ago

Should fix #26.

stkent commented 7 years ago 
* What went wrong:
A problem occurred configuring root project 'Lynx'.
> Could not resolve all dependencies for configuration ':classpath'.
   > Could not download asm-debug-all.jar (org.ow2.asm:asm-debug-all:5.0.1)
      > Could not get resource 'https://jcenter.bintray.com/org/ow2/asm/asm-debug-all/5.0.1/asm-debug-all-5.0.1.jar'.
         > java.lang.NullPointerException (no error message)
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
BUILD FAILED
Total time: 45.59 secs
The command "./gradlew checkstyle build" exited with 1.

🤷‍♂️

pedrovgs commented 7 years ago

Sorry for the late response @stkent. Thank you so much for this PR! 😃

Even when this is not the best implementation possible due to the usage of a synchronized modified shared by instance and being used to control the concurrent usage of two different resources, I think this implementation is valid. I think we can merge this PR as soon as the build passes in Travis CI.

I've restarted the build and if it fails, it should be related to the gradle configuration. If it fails, could you update the gralde configuration so we can merge this branch after seeing the build passing in Travis?

Thank you so much for your time and effort!

stkent commented 7 years ago

If you'd prefer I can switch to using synchronized blocks, it's a fast change :) Let me know!

pedrovgs commented 7 years ago

It's ok, thanks @stkent 😃 I'm merging this PR and waiting for #31 before releasing a new version.

Thanks for your time and contribution!