peerigon / clockodo

Unofficial JavaScript/TypeScript SDK for Clockodo
MIT License
20 stars 10 forks source link

feat: Add absenceManagersId #147

Closed Que-tin closed 1 year ago

Que-tin commented 1 year ago

But its the an array of ids of multiple managers. absenceManagerIds sounds like a single manager could have multiple ids.

So I'd say first is correct even tho I agree it sounds a bit odd.

P.s. I don't have rights to merge stuff.

jhnns commented 1 year ago

My array naming algorithm is as follows:

  1. How do you call one item in the array? It's an absenceManagerId
  2. Now pluralize it, hence absenceManagerIds

😁

I think both absenceManagerIds and absenceManagersIds make sense since it's a n:n relationship. But not absenceManagersId because it's missing the fact that it's an array of ids :)

Que-tin commented 1 year ago

Naming wont be changes as of now.