search

peering-manager / docker

🐳 Docker Image of Peering Manager
Apache License 2.0
9 stars 12 forks source link

Please do not specify ports in docker-compose.yml #20

Closed davidc closed 2 years ago

davidc commented 2 years ago

Please can you move this from docker-compose.yml to docker-compose.override.yml.example and add a note to the README that this file should be copied and configured.

services:
  peering-manager:
    ports:
      - 8080

Although I am specifying my own required ports 127.0.0.1:8001:8080 in docker-compose.override.yml, it seems that this is merged rather than overriding docker-compose.yml, resulting in a duplicate set of port mappings - the one from your file being wide open to the Internet if the sysadmin does not notice.

davidc commented 2 years ago

It's also worth noting that the default file also unnecessarily exposes port 8080 on the peering-manager-worker due to what I assume is inheritance.