search

peggyjs / peggy

Peggy: Parser generator for JavaScript
https://peggyjs.org/
MIT License
964 stars 65 forks source link

Update publish workflow. #554

Closed hildjj closed 2 months ago

hildjj commented 2 months ago

Fixes #552

hildjj commented 2 months ago

The only unclear thing for me is that expected that you will publish also on draft releases, or this situation is impossible? Otherwise relying on your experience

The type of release is set in two places. One is npm version prerelease --preid=alpha, which creates a version like "4.0.4-alpha.0" if the package is currently at version "4.0.3". That will be fully-supported by this flow.

The second is when you do the release, either with gh release create or in the GitHub site. Either of those have a mechanism to mark the release as "pre-release" and a second choice as to whether this release is "current". This set of choices will also be fully-supported by this flow.

Good question, and I'm glad that we have the workflow handy in case we need it.

hildjj commented 2 months ago

I think I'll also do a 4.1 pre-release to test this out, when I'm ready.

hildjj commented 2 months ago

Seeing no further comments, I'm going to land this. We can revisit as needed if anyone has other insights.