pelagios / recogito2

Semantic Annotation Without the Pointy Brackets
Apache License 2.0
152 stars 30 forks source link

IIIF filename: incomplete urlencoding #690

Closed docuracy closed 3 years ago

docuracy commented 3 years ago

We hit a snag due to the incomplete urlencoding of filenames in the document_filepart table. Colons are encoded as %2F but spaces remain unencoded. In our use case this caused a problem with a PHP file_get_contents call.

image

rsimon commented 3 years ago

I don't think that's something that Recogito even touches. The filenames are inserted as-is, i.e. this should be the URL you originally imported to Recogito. (And how it was included in the manifest.)

docuracy commented 3 years ago

Oops. Thanks, that would explain it!