search

pelargir / auto-session-timeout

Provides automatic session timeout in a Rails application.
MIT License
126 stars 63 forks source link

Compatablity issue with Rack 2.2.4 #40

Closed GearoidDC closed 1 year ago

GearoidDC commented 1 year ago

Hey,

I found an issue when upgrading to rack 2.2.4

For me it was only an issue on localhost ( Fine on production ) the logs would show a 200 status but the browser would view it as a 302 status.

image

image

I believe it is to do with this change in the rack gem. The Etag "" now gets read as an existing Etag rather removing it. https://github.com/rack/rack/pull/1919/files

In the PR I just set the Etag to nil instead of "" and it seems to work.

image

pelargir commented 1 year ago

Thank you!