Add empire support - Githubissues

pelias / placeholder

stand-alone coarse geocoder

https://placeholder.demo.geocode.earth

MIT License

314 stars 35 forks source link

Add empire support #54

Open trescube opened 6 years ago

trescube commented 6 years ago

Requesting dependencies doesn't include empires in hierarchy. Connects pelias/acceptance-tests#437

missinglink commented 6 years ago

can you please provide an example of this? I tried to reproduce this today without success.

missinglink commented 6 years ago

I tried US dependencies like The Virgin Islands, American Samoa and Puerto Rico. In all three cases the empire ID is visible in the spelunker but not in the source data.

missinglink commented 6 years ago

related https://github.com/whosonfirst/whosonfirst-www-spelunker/issues/129

missinglink commented 6 years ago

tried Cook Islands and the hierarchy has been completely deleted as per https://github.com/whosonfirst-data/whosonfirst-data/issues/954

missinglink commented 6 years ago

same for Niue, I'm going to stop digging now, there appear to be widespread issues with deleted hierarchies in WOF that surfaced recently.

I'm not sure if it's isolated to dependency records but they certainly seem badly affected.

missinglink commented 6 years ago

the functionality which adds empire to results seems to be working fine for other placetypes and I don't know any reason why it would differ for dependency, eg:

New Zealand country 85633345
└ New Zealand empire 136253053
   └ Oceania continent 102191583

nvkelso commented 6 years ago

Let's please be careful with adding Empire properties to Pelias. I'd 100% like to avoid labels like this:

1204 H St, Eureka, California, United States (country), United States (empire)

I'm also not 100% sure that we need to say XYZ Street, Locality, American Samoa, United States.

Tread into these political waters at your own risk!

trescube commented 6 years ago

We never include empire in the label so this shouldn't be a problem.

nvkelso commented 6 years ago

K. And if empire started showing up on a locality WOF record, say, would you pass that thru in Pelias hierarchy result?

trescube commented 6 years ago

We'll remove empires from the hierarchy unless there's no country, such as https://whosonfirst.mapzen.com/spelunker/id/85632421/

Unless you'd like that removed, too.

nvkelso commented 6 years ago

Keeping it on dependency is good with me.

On Tue, Oct 3, 2017 at 10:36 AM, Stephen K Hess notifications@github.com wrote:

We'll remove empires from the hierarchy unless there's no country, such as https://whosonfirst.mapzen.com/spelunker/id/85632421/

Unless you'd like that removed, too.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/pelias/placeholder/issues/54#issuecomment-333921012, or mute the thread https://github.com/notifications/unsubscribe-auth/AA0EOx9iONQkVjmojhhxMSXpLl0lIUoeks5sonCjgaJpZM4PmXll .