pelotech / drone-helm3

Plugin for drone to deploy helm charts using helm3
Apache License 2.0
31 stars 36 forks source link

WIP: support github runner action #118

Closed pradeepbbl closed 2 months ago

pradeepbbl commented 1 year ago

Feature: This is an initial draft idea to add support for github action there are few plugin already available in the market place but not good as this. So far the test are success but I would like to know your thoughts before make more changes/test.

This feature was control by environment var i.e runner when set to 'github', the envcofig prefix was set to INPUT (default is PLUGIN)

Sample Github Workflow

---
on: 
  push:
    branches:
      - master
jobs: 
  publish:
    runs-on: vm
    name: Deploy using Helm3
    needs: [build, lint]
    steps:
      - name: Checkout helm chart
        uses: actions/checkout@v3
        with:
          repository: spawnlab-dev/helm-spawnlab-apis
          token: ${{ secrets.PAT_TOKEN }}
          path: "spawnlab-apis"

      - name: Run lint
        env:
          runner: "github"
        id: helm-lint
        uses: spawnlab-dev/drone-helm3@pmishra/github_action
        with:
          mode: lint
          chart: ./spawnlab-apis

Screenshot 2023-10-09 at 14 10 57

Pre-merge checklist:

josmo commented 1 year ago

@pradeepbbl thanks for the proposed updates and I don't see anything against supporting both drone and github actions. It might be worth also refactoring the repo name and some other documentation if it's going to be a more generic helm runner. I haven't looked at creating github actions plugins but I'll take a look but definitely down to support it. I do imagine we just want it to be built by drone or actions and not both long run.

pradeepbbl commented 1 year ago

@josmo thanks for the quick response I will continue with the testing and will share the updates soon.

pradeepbbl commented 1 year ago

The test was success and able to build & test local build (based on current branch). I'll run few more test e.g. upgrade, uninstall etc.

Drone Build (local):

Screenshot 2023-10-10 at 01 32 03

Drone test run (local):

Screenshot 2023-10-10 at 01 28 20
josmo commented 2 months ago

@pradeepbbl I'm going to close this PR since it's been stale for a while - however feel free to open it back up if we want to bring this back to life :)