Add a "cleanup_on_fail" setting - Githubissues

pelotech / drone-helm3

Plugin for drone to deploy helm charts using helm3

Apache License 2.0

31 stars 36 forks source link

Add a "cleanup_on_fail" setting #65

Closed ErinCall closed 4 years ago

ErinCall commented 4 years ago

The problem I'm trying to solve: If someone wants to pass --cleanup-on-fail to helm upgrade, they should be able to do that

How I imagine it working:

Add an CleanupOnFail field to internal/helm.Config (be sure to set an envconfig tag)
Add an CleanupOnFail field to internal/run.Upgrade
Make sure internal/helm.upgrade passes the CleanupOnFail field when creating the Upgrade struct
Make sure Upgrade.Prepare adds --cleanup-on-fail to the helm args if CleanupOnFail is true