Closed bogdanS98 closed 3 weeks ago
Note:
- parachain-staking and issue pallets benchmarks are not yet included in any runtime.
- nomination , redeem , replace, vault-registry pallets benchmarks are not yet included in Pendulum runtime.
Should we just add them then or is there a good reason not to?
Please ensure that the collator nodes are redeployed after this PR is merged.
What changes require the redeployment of the collator nodes?
Should we just add them then or is there a good reason not to?
Yes, we should add them. They're not added yet because I'm still getting some errors on some benchmarks and I'm trying to fix them. Meanwhile everything that's already added in the PR can be reviewed as it's independent of the missing pallets.
What changes require the redeployment of the collator nodes?
I modified Cargo.toml
and chain_spec.rs
files from the node
directory; updated Spacewalk pallets versions and some minor changes in the genesis configs.
Is this now ready for a re-review or are you still adding more changes to it?
Is this now ready for a re-review or are you still adding more changes to it?
Still adding changes
@bogdanS98 what's the status with this? Do you need help here?
Any actions for us to take wrt the node upgrades @ebma ?
Good question @vadaynujra. @bogdanS98 in the description you mention that the nodes need to be redeployed. Looking at the PR, there are some changes to files in the node folder. However, to me it seems like these changes don't really require a redeployment. Changing the chain spec does not affect the operation of the nodes. What do you think?
@ebma Indeed changing the chain spec does not affect the operation of the nodes, I'll update the description 👍🏼
Closes #178.