search

pengxiangg / pe

0 stars 0 forks source link

Application becomes very slow after adding an itinerary of large date range #3

Open pengxiangg opened 4 years ago

pengxiangg commented 4 years ago

image.png

See Itinerary 4: large date range

The application will take very long to edit attractions even tho the attraction is not related to itinerary.

nus-pe-bot commented 4 years ago

Team's Response

Date range exceeds 1000 days. So the app is more prone to crash or hanging, which will result in following commands taking a longer time to respond. This is not part of our NFRs, as stated in our DG.

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Even though the large date range was related to itineraries, it should not have affected the other commands not related to itineraries, i.e. attractions, etc. However, even though a command not related to itineraries was executed, the command was still very slow, and made the application difficult to use, which seems to indicate that the design of the application was not done to separate out these component properly. Likewise, I feel like the team should have added a cap on the date range for each itinerary to prevent such things from happening, or at least fail gracefully.