search

pentacent / keila

Open Source Newsletter Tool.
https://keila.io
GNU Affero General Public License v3.0
1.33k stars 69 forks source link

No signature applied to text only campaigns #123

Closed JDPDO closed 1 year ago

JDPDO commented 2 years ago

No signature or the unsubscribe-link are send if the campaigns format is Text only. The chosen template is ignored.

wmnnd commented 2 years ago

Thanks for pointing this out! I’m not quite sure how to best address signatures in the context of plain-text campaigns. Do you have a suggestion for this?

In any case, I do think that the inclusion of an unsubscribe/manage preferences link should be mandatory.

JDPDO commented 2 years ago

I thought about that too. My idea would be to mimic the behaviour of default.html.liquid in the email templates folder. So there would be an default.txt.liquid with {{main_content}} and {{signature_content}} somewhere.

If the signature property of an template is in markdown, I would simply accept it as is and leave it up to the user.

I'll try to address this in my proposal #125.

wmnnd commented 1 year ago

With #175, signatures are now appended to plain-text campaigns.