search

pentacent / keila

Open Source Newsletter Tool.
https://keila.io
GNU Affero General Public License v3.0
1.33k stars 69 forks source link

`Keila.Mailings.Campaign` struct has obsolete field: `html_body` #126

Closed JDPDO closed 2 years ago

JDPDO commented 2 years ago

If I see correctly the field html_body of campaign is never used.

JDPDO commented 2 years ago

Wouldn't it be better if the fields html_body and text_body are merged. Maybe just body? The type of body would be clearly identifiable thanks to campaign.settings.type (Keila.Mailings.Campaign.Settings).

wmnnd commented 2 years ago

It isn’t so much that the field is obsolete, it’s more that it’s not used yet. The original idea behind having both fields would be that there could be campaign types that allow users to change the HTML body and text body independently. E.g. if we introduce a HTML block editor, users still might want to modify the plain text version of their emails.