Misconfigured sender leads to undefined behavior and broken stats

pentacent / keila

Open Source Newsletter Tool.

https://keila.io

GNU Affero General Public License v3.0

1.33k stars 69 forks source link

Misconfigured sender leads to undefined behavior and broken stats #142

Closed ja2ui0 closed 1 year ago

ja2ui0 commented 2 years ago

When Keila has a bad URL (ie: smtp.google.org instead of .com) and I try to send a campaign it hangs on "This campaign is currently being sent out. 0/1" forever and there's nothing showing up in the logs. Also, the campaign cannot be canceled.

wmnnd commented 2 years ago

Thanks for reporting this issue. You’re right, if the sender is misconfigured a campaign can currently enter an undefined state.

My recommendation if you’re currently stuck with this would be to clone the campaign and try again with a working sender.

wmnnd commented 1 year ago

This problem is fixed in #173 which makes campaigns with broken senders fail quickly.

wmnnd commented 1 year ago

Keila 0.11.0 (#173) now quickly fails when an email can't be sent out. In a future version I’ll add an improved retry mechanism.