pentacent / keila

Open Source Newsletter Tool.
https://keila.io
GNU Affero General Public License v3.0
1.33k stars 69 forks source link

URL_PORT default seems to be wrong or documentation misleading #149

Closed throny closed 1 year ago

throny commented 1 year ago

Hi,

according to the official docs the URL_PORT should be 80 if URL_SCHEMA is set to http (which is the default value) That seems to be not the case if the PORT is on 4000 as the mail confirmation for registration appends :4000 to the URL.

Right now it's required to set the URL_PORT to 80 manually.

Best, Moritz

wmnnd commented 1 year ago

Thanks for pointing this out; are you referring to the log message you get when starting Keila? That message seems to be indeed incorrect because URL_PORT doesn’t default to 80.

aqua-institut commented 1 year ago

Hi, nope, I meant the generated link in the activation mail when running with the defaults (host port 80 to internal 4000, leaving URL_SCHEMA and URL_PORT unset)

black-fake commented 1 year ago

Hi,

same "problem" here with https schema.

After manually setting URL_PORT to 443 the creation of links for the subscription form works well but before that there was automatically appended the port 4000 to the URL.

Seems to be the default value, no matter, if URL_SCHEMA is set or not

wmnnd commented 1 year ago

Thanks for your feedback! I’ve slightly updated the configuration behavior and the relevant documentation:

-> https://www.keila.io/docs/configuration