search

pentacent / keila

Open Source Newsletter Tool.
https://keila.io
GNU Affero General Public License v3.0
1.33k stars 69 forks source link

Add Phoenix.LiveView.HTMLFormatter #153

Closed wmnnd closed 1 year ago

wmnnd commented 1 year ago

We should enable the Phoenix HTMLFormatter to ensure consistent formatting in heex templates. https://hexdocs.pm/phoenix_live_view/Phoenix.LiveView.HTMLFormatter.html

panoramix360 commented 1 year ago

I was planning on doing this one, but I noticed that the HTMLFormatter has a limitation in using Elixir >v13.4

image

Do you plan to update Elixir on the project?

wmnnd commented 1 year ago

Yes, we should definitely upgrade to Elixir 1.14. Would you like to prepare a PR for that?

panoramix360 commented 1 year ago

yep, I can upgrade it 🤓

panoramix360 commented 1 year ago

@wmnnd I'll try to tackle this one now on upgrading Elixir :)

panoramix360 commented 1 year ago

I'll work on this once we got the #173 merged, it will upgrade Elixir so this will be available to work on.

panoramix360 commented 1 year ago

@wmnnd I believe you forgot to close this issue :)

wmnnd commented 1 year ago

True! Thanks again for implementing this in #214