penumbra-zone / web

Apache License 2.0
15 stars 16 forks source link

Add ReactNode to Toast description prop type #1899

Closed JasonMHasperhoven closed 3 weeks ago

JasonMHasperhoven commented 3 weeks ago

Add ReactNode to Toast description prop type.

Needed to provide a progress bar to the transaction toast.

changeset-bot[bot] commented 3 weeks ago

🦋 Changeset detected

Latest commit: 2b58f3be56150093a2681b1c8524466165d8ca6f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages | Name | Type | | --------------------- | ----- | | @penumbra-zone/ui | Minor | | minifront | Patch | | node-status | Patch | | @repo/tailwind-config | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 3 weeks ago

Visit the preview URL for this PR (updated for commit 2b58f3b):

https://penumbra-ui-preview--pr1899-toast-prop-type-wqoev08o.web.app

(expires Mon, 11 Nov 2024 13:23:37 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 709d729610ef7a6369b23f1cb2b820a60cc685b1

JasonMHasperhoven commented 3 weeks ago

nitpick: in string | ReactNode, the string | part could be removed

Just curious, why is it preferred?