Chore: add linter - Githubissues

peopledoc / OPE

One Page for Equity

3 stars 0 forks source link

Chore: add linter #27

Open saintsebastian opened 4 years ago

saintsebastian commented 4 years ago

adds eslinter config
initializes a node project (package.json)
marks broken file (i will gladly provide help to lint them)
adds CircleCI config
adds docs about running project

TODO:

setup the repo and a circleCI projec (for example using https://medium.com/meshstudio/continuous-integration-with-circleci-and-nodejs-44c3cf0074a0)

superette commented 4 years ago

Great to have a linter! I think we should let do the "fix" part to the last author of lines, this way we don't loose history on commiter, and author can practice with the new syntax conditions

nadege commented 4 years ago

I'm good with the styling choices (no ; yay ! :D )

Will you add a bit of CI with this PR too ?

saintsebastian commented 4 years ago

@nadege i was planning this too, TRAVIS CI offers free support for OS projects afaik

nadege commented 4 years ago

yes, circleci do that too. (you may be more familiar with it? as we use it for other projects)

saintsebastian commented 4 years ago

@superette i assume you have right to turn on circleCi for this repo. Do you see settings tab on the top? if yes lets have a call and turn it on