peopledoc / mlvtools

Public repository for versioning machine learning data
Other
42 stars 7 forks source link

the :param relations to generated dvc bash scripts and dvc-in arguments are confusing in docs #84

Open antonkulaga opened 4 years ago

antonkulaga commented 4 years ago

I have multiple string parameters in notebooks. In the beginning I thought that all the params I declare as :param in docstrings should be automatically passed to dvc bash script as dvc -p because it looked intuitive. However, it is not the way how generated DVC bash work: I do not see acceptance of the :param arguments which I declared in DVC bash scripts which are generated. I think the documentation should clarify how/if DVC bash scripts interact with :param arguments, otherwise it leads to a lot of confusion and wasted time

SdgJlbl commented 4 years ago

Hello, Thank you for your issue and sorry for the late reply - I was not notified by Github for some reasons...

Thank you for your feedback, I'll try to clarify the documentation with respect to that point. In the mean time:

We plan to add support for DVC parameters and DVC metrics very soon.

By curiosity, could you tell me which part of the documentation did you use the most? Did you rely on the project README, or did you also have a look at the tutorials (https://github.com/peopledoc/mlvtools-tutorial)? Thank you, and sorry again for missing your issues.