search

pepkit / looper

A job submitter for Portable Encapsulated Projects
http://looper.databio.org
BSD 2-Clause "Simplified" License
19 stars 7 forks source link

force yes in Cleaner #131

Closed stolarczyk closed 5 years ago

stolarczyk commented 5 years ago

Why does the --force-yes option not influence the Cleaner call?

https://github.com/pepkit/looper/blob/2fea256b7278198f1211656dad27f1ef7e92c305/looper/looper.py#L156-L159

compare with Destroyer where we take that into consideration:

https://github.com/pepkit/looper/blob/2fea256b7278198f1211656dad27f1ef7e92c305/looper/looper.py#L197-L201

This makes the looper clean invalid in caravel

vreuter commented 5 years ago

In build_parser we only add that option to the destroy subparser.

stolarczyk commented 5 years ago

should we add it to clean subparser, then?

vreuter commented 5 years ago

That’s fine with me

nsheff commented 5 years ago

yes.

stolarczyk commented 5 years ago

Added on branch jinja