search

peq / wurstStdlib

Wurst standard library
3 stars 2 forks source link

fix OnUnitEnterLeave #16

Closed BlueSaint closed 8 years ago

peq commented 8 years ago

Removing the nullTimer is not really a good solution I think.

Before the change you could register the event and have it called for units already on the map because of the nulltimer. Now GroupEnumUnitsInRect will be called before anyone was able to register a callback, so it becomes useless.

That's why I suggested keeping a group of units currently on the map.

Frotty commented 8 years ago

and maybe squash the commits to one

peq commented 8 years ago

Squashing is not necessary. I can squash them when accepting the request.

peq commented 8 years ago

Merged other branch.