search

percussion / percussioncms

Percussion CMS - Content Management System
https://percussioncmshelp.intsof.com/percussioncms
Apache License 2.0
11 stars 9 forks source link

Image Slider Widget: Implement a toggle for target =_blank property in external links #602

Closed mariosm1 closed 2 years ago

mariosm1 commented 2 years ago

Currently all external links are set to create a new tab with the property target=_blank. This feature request would add a new toggle to the layout properties so that this property can be removed by users.

natechadwick commented 2 years ago

This could be done by modifying system/Packages/perc.widget.imageSlider/sys__UserDependency--rxconfig/Widgets/percImageSlider.xml and adding a layout property (maybe an enum) for the link target.

The link target (search on target=) is in 3 places that would need to be updated to read the new layout property. The default value for the new property would need to be _blank so as not to cause upgrade issues.

natechadwick commented 2 years ago

@mario-percussion I think all that is left on this is updating the version info for the widget so it updates correctly on upgrade.

mariosm1 commented 1 year ago

Tested all target=_ options for internal and external links, also tested the "Images are links" checkbox in the image slider layout properties. All of these are working.