search

percy / in-percy

@percy-io/in-percy NPM package
MIT License
2 stars 4 forks source link

Fix typing issue in-percy.d.ts #5

Closed jruhland closed 6 years ago

jruhland commented 6 years ago

fixes:

TS1046: A 'declare' modifier is required for a top level declaration in a.d.ts file.

timhaines commented 6 years ago

Thanks @jruhland!

jruhland commented 6 years ago

sure thing, can you let me know when you re-publish, right now im using a local workaround in our codebase

timhaines commented 6 years ago

@jruhland I've published it now, as v0.1.11. I'd be curious to hear what you're doing to receive this warning. Are you linting the in-percy.d.ts file somehow?

jruhland commented 6 years ago

we are using inPercy in a storybook definition, and it was tossing it on build. The code was still working since we are running the checker on a separate thread, but the warning was annoying, so i thought id fix it for ya.

jruhland commented 6 years ago

i was actually very curious why exactly this is as well, since node_modules is ignored.

Appreciate the publish, thanks