percy / percy-capybara

Visual testing for Capybara with Percy.
https://docs.percy.io/docs/capybara
MIT License
45 stars 23 forks source link

Require Percy version file specifically #108

Closed nikz closed 5 years ago

nikz commented 5 years ago

If other version.rb files are in the load path, then it'll load them instead leading to fun conflicts (error message in Rails is along the lines of: Unable to autoload constant VERSION...)

This requires the Percy version file specifically. I believe other gems have solved this by using a subfolder under /lib that contains the Gem name rather than adding generic files in lib to the load path which might cause more fun errors in future :) Happy to send a PR with that change too if you'd like!

djones commented 5 years ago

Thanks @nikz!