don't try to upload duplicated resources

percy / percy-capybara

Visual testing for Capybara with Percy.

https://docs.percy.io/docs/capybara

MIT License

45 stars 23 forks source link

don't try to upload duplicated resources #33

Closed mikz closed 4 years ago

mikz commented 7 years ago

@fotinakis this builds on top of https://github.com/percy/percy-client/pull/13

resources can get duplicated when their paths are mix of absolute and relative ones. https://github.com/percy/percy-client/pull/13 allows making them unique just by calling Array#uniq

another approach would be to move https://github.com/percy/percy-capybara/blob/c165c1979ad254070c3e12035e49c700ab689302/lib/percy/capybara/loaders/native_loader.rb#L145 after the url was normalized few lines below

Robdel12 commented 5 years ago

Probably safe to close this since v4 has been released and removes loaders? @fotinakis