percy / percy-capybara

Visual testing for Capybara with Percy.
https://docs.percy.io/docs/capybara
MIT License
45 stars 23 forks source link

Agent-based version of Percy Capybara #69

Closed anaulin closed 5 years ago

anaulin commented 5 years ago

Welcome to the new version percy-capybara, now @percy/agent-based! 🎆

Aside from the substantially smaller implementation (thanks, @percy/agent), the main changes in this PR are:

In terms of compatibility, after upgrading to this version, users will need to:

In the "what is Ruby, even" category, I'm sure you'll have comments on style, and on my use of return (yay? nay?). I am uncertain if the file/directory structure that we have now in this package follows Ruby gem idioms. In particular, percy/capybara.rb now contains only code for the Percy module. Not sure if that's kosher or not.

@fotinakis for review, @Robdel12 fyi

anaulin commented 5 years ago

The CI build on this PR is now green, module getting approval on the visual diff in: https://percy.io/percy/percy-capybara/builds/1504564

anaulin commented 5 years ago

I blame node for messing up the nice code deletion stats in this PR. screen shot 2019-03-01 at 10 50 16 am screen shot 2019-03-01 at 10 50 29 am

anaulin commented 5 years ago

@fotinakis i believe i've addressed all your comments on this code, please have another look

anaulin commented 5 years ago

The branch I created before starting this PR, with the changes at master for percy-capybara version 3.2.0 are on branch: pre-agent-v320 (https://github.com/percy/percy-capybara/tree/pre-agent-v320)