search

percy / percy-capybara

Visual testing for Capybara with Percy.
https://docs.percy.io/docs/capybara
MIT License
45 stars 23 forks source link

Webpacker 4 #76

Closed vitalinfo closed 5 years ago

vitalinfo commented 5 years ago

After upgrade Webpacker 4 have problem with screenshots on pages switch are using pack CSS. Does it known issue?

djones commented 5 years ago

Hi @vitalinfo, sorry about the issues here. Which version of percy-capybara are you using?

vitalinfo commented 5 years ago

@djones 3.2.0

vitalinfo commented 5 years ago

@djones looks like I've found work around with webpacker configuration

djones commented 5 years ago

@vitalinfo good to hear!

Just a little follow up here... we've been working on v4, a new major version of percy-capybara. We've pre-released this new version and it does away with loaders, therefore your webpacker configuration shouldn't matter at all.

Here is our upgrade guide to help you migrate from percy-capybara v3 to v4.

vitalinfo commented 5 years ago

Thanks

On Apr 1, 2019, at 5:39 PM, David Jones notifications@github.com wrote:

@vitalinfo https://github.com/vitalinfo good to hear!

Just a little follow up here... we've been working on v4, a new major version of percy-capybara. We've pre-released this new version https://rubygems.org/gems/percy-capybara and it does away with loaders, therefore your webpacker configuration shouldn't matter at all.

Here is our upgrade guide to help you migrate from percy-capybara v3 to v4 https://docs.percy.io/docs/upgrading-to-v4.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/percy/percy-capybara/issues/76#issuecomment-478606768, or mute the thread https://github.com/notifications/unsubscribe-auth/AHLLbqDo5v2MGvfzbKYQ_LbbEBXr4D3_ks5vchoTgaJpZM4cUd0_.

doutatsu commented 5 years ago

@vitalinfo Could you provide what you did with your configuration? I am facing the same issue and v4 upgrade didn't help me I am afraid @djones

vitalinfo commented 5 years ago

@doutatsu I've added extract_css: true to the test webpacker.yml config

doutatsu commented 5 years ago

You saved me @vitalinfo! Spent a month upgrading to webpack 4 and thought I'll be stuck with Percy now. This fixes it, huge props to you!