Duplicate snapshot name in a parallel build causes missing snapshots

[esetnik]

https://github.com/percy/percy-cypress/blob/9e41a394274ae35635b774b735098254965e74b4/index.js#L75

The catch block should rethrow the error to fail the test if there is an error generating the snapshot.

[github-actions[bot]]

This issue is stale because it has been open for more than 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

[esetnik]

@Robdel12 please mark as not stale

[github-actions[bot]]

This issue is stale because it has been open for more than 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

[esetnik]

@Robdel12 please mark as not stale

[itsjwala]

Hey @esetnik 👋

we'll look into this issue.

++ @samarsault

[samarsault]

@esetnik Can you share the build url and a reproducible example for this?

[esetnik]

I cannot share a private project. Here's a build url for you.

https://percy.io/283b5e1b/ProdigyEMS/builds/23569245/unchanged/1317616280?browser=firefox&viewLayout=side-by-side&viewMode=new&width=1280

[github-actions[bot]]

This issue is stale because it has been open for more than 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

[itsjwala]

Hi @esetnik 👋

The modified cypress SDK can be installed from this git repo by using this command: npm i --save-dev https://github.com/BrowserStackCE/percy-cypress.git

What it looks like in the package.json file: "@percy/cypress": "github:BrowserStackCE/percy-cypress"

we'll be merging this upstream post doing some regression.

[esetnik]

@itsjwala is this project abandoned? I didn't get any review of my PR and it was closed with no comment. https://github.com/percy/percy-cypress/pull/569

[itsjwala]

Hi @esetnik nope, I'll reopen it. Currently we're doing regression on our side.

[esetnik]

You should disable your github-actions since the repository is not being monitored it keeps marking things as stale that have not received any attention from a percy team member.

[itsjwala]

@esetnik apologies we're improving our processes for this.

Also coming to your original issue for which this is raised. can you check if https://github.com/percy/cli/issues/281#issuecomment-1276602390 helps in resolving your issue?