search

percy / percy-ember

Ember addon for visual regression testing with Percy
https://docs.percy.io/docs/ember
MIT License
73 stars 44 forks source link

Percy running for each Ember Try scenario #4

Closed elidupuis closed 8 years ago

elidupuis commented 8 years ago

Just started using Percy (thanks so much!) and I'm wondering if there's a way to avoid diffing each scenario that Ember Try runs?

I can see the benefit of running and diffing in every scenario but I can also see wanting to only run in the default scenario. Any thoughts?

fotinakis commented 8 years ago

Hey @elidupuis! Yes, you can set the PERCY_ENABLE=0 environment variable to disable it. For example, we do this for the ember-percy addon itself in our travis.yml: https://github.com/percy/ember-percy/blob/master/.travis.yml#L14

So the best way to do this would be to set PERCY_ENABLE=0 by default in your test environment, and then set PERCY_ENABLE=1 for the one ember-try scenario you want visual coverage for.

Let me know if that doesn't work!

elidupuis commented 8 years ago

Oh, awesome! I'll give that a try. Thanks!

amyrlam commented 2 years ago

How do you enable this option in GitHub Actions? Took a look at https://github.com/percy/percy-ember/tree/master/.github/workflows, but am not sure

Robdel12 commented 2 years ago

Hey @amyrlam! You would want to toggle PERCY_ENABLE for each job in the matrix here: https://github.com/hashicorp/design-system/blob/main/.github/workflows/ci-components.yml#L87-L89 You'd look at ${{ matrix.try-scenario }} and decide if you wanted to set PERCY_ENABLE to 1 or 0

amyrlam commented 2 years ago

@Robdel12 thank you, I'm sorted! (For some reason I still find GitHub Actions a lot more confusing than Travis)