search

percy / percy-ember

Ember addon for visual regression testing with Percy
https://docs.percy.io/docs/ember
MIT License
73 stars 44 forks source link

Recent `@percy/sdk-utils` change breaks AMD import #610

Closed dfreeman closed 2 years ago

dfreeman commented 2 years ago

The problem

Starting 2 days ago, our nightly "forget the lockfile and see what happens" compatibility tests for our design system package started failing due to test loader errors. I've tracked it down to @percy/ember failing to load @percy/sdk-utils due to the change that landed in https://github.com/percy/cli/pull/1000

the Chrome debugger paused while attempting to call the string '@percy/sdk-utils' as a function

Environment

Code to reproduce issue

This should be reproducible in this repo by refreshing the @percy/sdk-utils entry in the lockfile here.

wwilsman commented 2 years ago

Hey @dfreeman!

Can you give @percy/ember v3.0.1 a try? 🤞

dfreeman commented 2 years ago

That looks like it did the trick—thank you for the quick fix!