Snapshots during retries cause errors

[JackCA]

The problem

playwright supports retries but when a snapshot is taken in a retry, we get an error:

Error: The name of each snapshot must be unique, and this name already exists in the build: 'foo' -- You can fix this by passing a 'name' param when creating the snapshot. See the docs for more info on identifying snapshots for your specific client: https://percy.io/docs

Environment

• Node version:
• @percy/cli version: 1.0.0-beta.70
• Version of Percy SDK you’re using: percy/playwright 1.0.1
• If needed, a build or snapshot ID: n/a
• OS version: n/a
• Type of shell command-line [interface]: n/a

Details

It looks like there is work that was merged into core related to this but I don't think the sdk supports using this functionality?

Other related discussions:

• https://github.com/percy/cli/issues/281
• https://github.com/meinaart/cypress-plugin-snapshots/pull/141

Code to reproduce issue

in playwright.config add retries: 2

in a test.spec.ts:

test('foo', async (page) => {
  snapshot(page, 'foo')
 throw new Error('run retry')
})

[unlikelyzero]

@JackCA I think you should consider creating a separate visual testing profile with retries disabled. I've been doing visual testing for 3 years and now create multiple e2e profiles: one for CI and one for Visual Tests

[JackCA]

@JackCA I think you should consider creating a separate visual testing profile with retries disabled. I've been doing visual testing for 3 years and now create multiple e2e profiles: one for CI and one for Visual Tests

Definitely agree with you there -- I'm doing my best to prevent even needing retries. However, I still think this would be a valuable feature and think the opportunity is there because of the upstream changes made to core.

[Robdel12]

Hey @JackCA! Going to close this out since the CLI ticket you linked to is the right place to track it. We'll be shipping retry support after 1.x in early 2022.

[JackCA]

great, thanks @Robdel12