percy / percy-storybook

Percy's Storybook SDK.
https://docs.percy.io/docs/storybook
MIT License
149 stars 45 forks source link

storybook: unknown property #731

Closed zkrzyzanowski closed 1 year ago

zkrzyzanowski commented 1 year ago

The problem

After upgrading to storybook v7 and trying to run snapshots we get the following error:

pnpm percy config:validate
[percy] Found config file: .percy.yml
[percy] Invalid config:
[percy] - storybook: unknown property
version: 2
storybook:
  args: {}
  globals: {}
  queryParams: {}
  waitForTimeout: 10000
  waitForSelector: ''
  additionalSnapshots: []
  include:
    [
      'percy - all fiber components',
      'percy webcomponents - all fiber components',
    ]
  exclude: []

tried removing node_modules and reinstalling, this happens locally and in our CI environment

Environment

Details

If necessary, describe the problem you have been experiencing in more detail.

Debug logs

If you are reporting a bug, always include logs! Give the "Debugging SDKs" document a quick read for how to gather logs

Please do not trim or edit these logs, often times there are hints in the full logs that help debug what is going on.

Code to reproduce issue

Given the nature of testing/environment bugs, it’s best to try and isolate the issue in a reproducible repo. This will make it much easier for us to diagnose and fix.

zkrzyzanowski commented 1 year ago

this may be related to this issue

zkrzyzanowski commented 1 year ago

We downgraded to version 1.22.0 and that appears to have solved the initial issue, but now we're seeing the same error as listed in this issue

github-actions[bot] commented 1 year ago

This issue is stale because it has been open for more than 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

samarsault commented 1 year ago

Similar to https://github.com/percy/percy-storybook/issues/715

github-actions[bot] commented 1 year ago

This issue is stale because it has been open for more than 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

github-actions[bot] commented 1 year ago

This issue was closed because it has been stalled for 28 days with no activity.