Javascript vs Ruby

[jasikpark]

This takes a full minute longer to run than the cli does on Netlify.

Percy Agent is much slower than the original cli.

[Robdel12]

Hey Caleb! That's correct, the old CLI would only upload the assets to the API, where the browsers would render the page directly. The new CLI opens a puppeteer browser, iterates through the static files, and captures DOM snapshots (fully rendered pages). This is inline with how all our other SDKs function.

You're free to keep using the old Ruby CLI 👍

[jasikpark]

Is there any functional difference between the data they capture?

Caleb Jasik
calebjasik@jasik.xyz(mailto:calebjasik@jasik.xyz) https://jasik.xyz

On January 30, 2020 at 10:27:24 AM, Robert DeLuca (notifications@github.com(mailto:notifications@github.com)) wrote:

Hey Caleb! That's correct, the old CLI would only upload the assets to the API, where the browsers would render the page directly. The new CLI opens a puppeteer browser, iterates through the static files, and captures DOM snapshots (fully rendered pages). This is inline with how all our other SDKs function.

You're free to keep using the old Ruby CLI 👍

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub(https://github.com/percy/snapshot-action/issues/8?email_source=notifications&email_token=ACRCMJB2LJRQX3DPYZKQQV3RAL5WZA5CNFSM4KNNMVWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKLTVAI#issuecomment-580336257), or unsubscribe(https://github.com/notifications/unsubscribe-auth/ACRCMJBNROTPLPU2GF36FX3RAL5WZANCNFSM4KNNMVWA).

[Robdel12]

Yeah, the new SDK will capture fully rendered DOM with JS enabled when going taking snapshots. The old Ruby SDK just uploaded the HTML and then rendered that as is in our browsers (JS disabled by default)

[jasikpark]

Ok, I see now -- it's moving the time from y'all's service to the actual CI service -- resulting in about the same amount of time till it's done.