[feature] Search action webhook payload for required keys (branch/ref, pr number)

percy / storybook-action

[Deprecated] A GitHub action to run Percy with Storybook

https://docs.percy.io/docs/github-actions#section-storybook-action

MIT License

11 stars 5 forks source link

[feature] Search action webhook payload for required keys (branch/ref, pr number) #13

Closed covertbert closed 2 years ago

covertbert commented 4 years ago

I submitted a PR to you guys the other with a suggestion on how the action might be fixed to accommodate workflow runs that are triggered by the pull_request_review event. Apologies for not making it clear but I didn't intend for it to be merged without testing as I hadn't tested it myself!

Anyway, the action is now broken on the latest release and won't work for the pull_request event either. Do you guys have the bandwidth to take a proper look at this and fix it?

Robdel12 commented 4 years ago

This should be "fixed" with v0.1.5. The issue wasn't setting the PR number in this workflow trigger, the issue is the branch ref is in a different place (which caused the 💥 on replace of a undefined string).

I'll hopefully have a follow up PR that makes it easy to search the entire webhook payload for the info we need. It's clear no payload matches the same shape, so we're going to constantly play this game.

covertbert commented 4 years ago

Awesome, thanks for dealing with this so quickly!