search

percyqaz / UltimateInventory

Minecraft server plugin to streamline inventory management - Supports PaperMC and SpigotMC
https://www.spigotmc.org/resources/ultimate-inventory-1-19-1-20.109298/
MIT License
9 stars 2 forks source link

Plugins compatible with stacking empty shulker boxes #2

Closed ApliNi closed 1 year ago

ApliNi commented 1 year ago

resolve https://github.com/percyqaz/Shulkerbox/issues/1

I can't seem to build the plugin, you might want to test it with a compiler

ApliNi commented 1 year ago

Have you considered using Maven to manage projects? I think it is very useful, you can take a look at https://github.com/ApliNi/Shulkerbox/tree/main

Actually I will only create and compile plugins with this (

percyqaz commented 1 year ago

Great work, it all works! I can't find any problems (I tested with dying, disconnecting and crashing as well as hotkeys in the inventory) Thanks very much, I will merge this now

I also have an idea: Do we need to store random data in the NBT? I think only one shulker box will exist with the NBT tag in a player's inventory, so we can use a constant value

I'll investigate that while I prepare a release of version 1.2

Have you considered using Maven to manage projects?

I actually don't write a lot of Java so I'm not familiar with any of its build systems. The last time I tried to use a build system (a while ago) it was annoying to set up so I stuck to something that works and I understood.

If I update this plugin more or make other plugins I'll look into it properly :)

ApliNi commented 1 year ago

I also have an idea: Do we need to store random data in the NBT?

Maybe it will work fine on this stack plugin, but for better compatibility with other stack plugins, it is necessary to store some random data (at least there is nothing wrong with doing so)